Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Slimdown store coupon templates #164

Merged
merged 10 commits into from
Apr 2, 2017
Merged

Slimdown store coupon templates #164

merged 10 commits into from
Apr 2, 2017

Conversation

arowM
Copy link
Contributor

@arowM arowM commented Apr 2, 2017

This PR slims down template files regarding to Kucipong.Handler.Store.Coupon.
Also, it removes codes about image uploading, which will be done by more user friendly way with JSON API.

  • 6d9edd1 and fb6f67d slims down coupon create pages.
  • 00ab4da slims down coupon edit pages.
    • (This commit also make it easy to handle query parameters.)
  • 34bf098 gets rid of codes to update image from coupon POST API.

Issue #163 will make query parameters more maintainable.

@arowM arowM requested a review from cdepillabout April 2, 2017 10:02
@arowM arowM mentioned this pull request Apr 2, 2017
Closed
@cdepillabout
Copy link
Contributor

LGTM! 👍

@cdepillabout cdepillabout merged commit 50cfcf1 into blueimpact:master Apr 2, 2017
@cdepillabout cdepillabout mentioned this pull request Apr 2, 2017
Open
@arowM arowM deleted the slimdown-store-coupon-templates branch April 3, 2017 03:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cdepillabout cdepillabout Awaiting requested review from cdepillabout

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@arowM @cdepillabout