Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

URI is OPTIONAL in EXT-X-MEDIA tag #104

Merged
merged 3 commits into from
Nov 22, 2023
Merged

URI is OPTIONAL in EXT-X-MEDIA tag #104

merged 3 commits into from
Nov 22, 2023

Conversation

Lysander66
Copy link
Contributor

URI is OPTIONAL in EXT-X-MEDIA tag, see rfc8216(https://datatracker.ietf.org/doc/html/rfc8216#section-4.3.4.1)

@codecov
Copy link

codecov bot commented Oct 24, 2023

Codecov Report

Attention: 24 lines in your changes are missing coverage. Please review.

Comparison is base (75f058a) 69.32% compared to head (fa77cba) 69.36%.
Report is 4 commits behind head on main.

Files Patch % Lines
client_downloader_primary.go 0.00% 21 Missing ⚠️
pkg/playlist/multivariant_rendition.go 78.57% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #104      +/-   ##
==========================================
+ Coverage   69.32%   69.36%   +0.03%     
==========================================
  Files          42       42              
  Lines        3632     3649      +17     
==========================================
+ Hits         2518     2531      +13     
- Misses        928      931       +3     
- Partials      186      187       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aler9 aler9 merged commit 30c4379 into bluenviron:main Nov 22, 2023
7 of 8 checks passed
@aler9
Copy link
Member

aler9 commented Nov 22, 2023

Hello, thanks for this PR, i had to adapt the client in order to support this change. This has been merged.

@github-actions github-actions bot locked and limited conversation to collaborators May 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants