First attempt at implementing wildcard paths #52
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apologies for the duplicate earlier on, should have been less jumpy about opening an issue!
First attempt at getting this working, based on my limited understanding of RTSP and the code structure.
This patch introduces a new configuration item:
isWildcard
, that causes the configured path to be matched against any path that begins with it. TherunOnInit
/runOnDemand
/runOnPublish
/runOnRead
callers have also been modified to set an environment variable RTSP_SERVER_PATH with the calling path. (For runOnInit, it will be called with the configured path, of course)findConfForPath()
has been modified to return an additional string - the configured path that was matched. It isn't necessary at the moment (only used to print out logs), but might be useful to have.There are some doubts I have:
isWildcard
is set for the 'all' pathDo let me know how I can improve the patch for acceptance, thanks!
(Addresses #47 )