Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement binary ops as functions #132

Merged
merged 11 commits into from
May 2, 2021
Merged

Implement binary ops as functions #132

merged 11 commits into from
May 2, 2021

Conversation

bluescarni
Copy link
Owner

No description provided.

@bluescarni
Copy link
Owner Author

@darioizzo this PR removes the binary_operator node type, re-implementing binary arithmetic functions using func instead. I think the adaptations for the GP support should be fairly straightforward (and I did some of them), but not being familiar with that part of the code, I just commented out the tests that now fail.

@bluescarni bluescarni merged commit cf35dee into master May 2, 2021
@bluescarni bluescarni deleted the pr/bops_func branch May 2, 2021 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@bluescarni