-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Polynomial division #52
Conversation
build_system: enable the -Wodr flag if supported.
…ns use the decay type.
Testing and documentation still to be done.
…c for the algorithm selection. Tests still to be written.
@certik @isuruf @rwst pinging in case you are interested So this is Piranha's first foray into poly division and GCD. I implemented both exact multivariate polynomial division and GCD over generic UFDs. Just to make things clear since the beginning, performance is going to be horrid. This is due to two root causes:
I consider the first point to have a higher priority than the second. If anything, I think we need to have a good implementation of the primitive data structures before comparing algorithmic performance. Despite the performance problems, the code is as tested as any new feature I have implemented in Piranha so far and at this point I am not aware of correctness bugs. I made sure to have 2 GCD implementations available so I could compare the results of the two as an additional check. I'll merge the PR tomorrow when all the checks are run. |
@bluescarni cool, that's exciting. Thanks for letting us know. |
Some initial code for polynomial division and GCD. Work in progress.