Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pagination on app.bsky.feed.getPostThread #2351

Closed
lokxii opened this issue Mar 20, 2024 · 1 comment
Closed

Pagination on app.bsky.feed.getPostThread #2351

lokxii opened this issue Mar 20, 2024 · 1 comment

Comments

@lokxii
Copy link

lokxii commented Mar 20, 2024

Currently there is no pagination on getPostThread. But a community on bsky just created a post with 1060 replies.

Calling getPostThread gives a 2MB json response and setting depth to 1 gives slightly more than 1MB json response. While clients seem to be able to handle this amount of data, is it really not a problem to return this amount of data in single request? I am not a web dev so I'm not sure what is the average response size of a response but I never saw a 2MB json response.

Now the original author of the post is replying to every single comments. I can see the response json will get a lot bigger.

Just curious is this behavior expected?

@devinivy
Copy link
Collaborator

devinivy commented Apr 4, 2024

It's expected and usually not an issue, but also not ideal. There's a good chance we'll address this when we have an opportunity. It might require remodeling feed.getPostThread which has some other related limitations too, such as not being able to get posts above a deleted ancestor post.

@devinivy devinivy closed this as completed Apr 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants