-
Notifications
You must be signed in to change notification settings - Fork 554
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Labels !hide
and !warn
are taking effect even if labeler doesn't advertise them
#2367
Comments
@pfrazee should these labels take effect when they haven't been declared in the |
Even if they should - users must be able to configure their behaviour, at least on non-mandatory labelers. |
Here was when I asked whether clients should interpret definitions that are in |
Reminder: this is still an issue and a deal-breaker (at least for me) for subscribing to 3rd-party labelers. |
I understand users not wanting a moderation service to be able to hide things without any configuration setting, but informational labels can easily clutter the configuration UI. If there was some way to specify that a label that never hides or blurs content wasn't as important and have it appear in a collapsed or hidden state in the UI, that would be nice. Because there is nothing for the user to configure, with the exception of ignoring the label, this shouldn't be an issue. I hope this is a good compromise. |
Reiterating again, right now it affects local labeler-defined labels as well, and it's not clear whether they are:
I can only assume either point 1 or 2, it's a misconfiguration/not ready and therefore clients shouldn't be interpreting it, that's what I've done for Skeetdeck. If we want them to be non-configurable or hidden, then there should be a property for this. Point 1 or 2 also applies for global labels like |
Now that we've had a bit of time for the labeling system to bake, what i'm leaning towards:
|
I'm strongly opposed to some labelers receiving special treatment.
This should apply universally, full stop. Any deviation breaks abstraction layers between clients and labelers.
Please don't. You already have the power to disallow the user to turn them off. But overall it would be better if they're properly presented to the user.
Your focus on making centralized service made you miss the fact that labels should be namespaced. In this case, self-label should either come with a complete definition detached from any labeler, or contain a reference to the labeler that defines it.
Notification would be useful, but no content should be hidden until the user explicitly acknowledges the new label. One way to achieve that is to disallow hiding as a default value, but that might be not always convenient for everyone. |
Spotted in the wild: https://bsky.app/profile/did:plc:36h6ttx2g23zqr4accilbvo7/post/3kw5dhxv2572e |
Describe the bug
These two labels are still do something and hide content when they're coming from a labeler that doesn't advertise them.
To Reproduce
Steps to reproduce the behavior:
!hide
or!warn
tolabels
orpolicies
.!hide
to some other post or accountExpected behavior
Label should have no effect. User did not consent to sourcing that label from this particular labeler, and has no way to configure the behaviour.
Additional context
Non-configurable labels that hide content are bad enough of an intrusion already. What's worse is that there's no indication at subscription time that a particular labeler can issue them and silently remove content from your feed.
The text was updated successfully, but these errors were encountered: