Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return threads in a linear list #930

Open
mikuhl-dev opened this issue Apr 30, 2023 · 1 comment
Open

Return threads in a linear list #930

mikuhl-dev opened this issue Apr 30, 2023 · 1 comment

Comments

@mikuhl-dev
Copy link

I feel it is a bit hacky the way post threads are returned in a deeply nested object, which is causing problems with huge threads that are being made. Perhaps return threads in a linear list, and allowing for a certain few posts of context, then the actual requested post, and then replies and replies of replies (to a certain extent.) Each object could have a boolean set/unset if it is the tail of a thread, to draw the line underneath avatars you usually see. An algorithm field could be added to to the procedure to allow different ways for the PDS to choose which threads to show, but perhaps by default prioritizing threads that contain the OP, and otherwise the most likes.

For example, without context, it is nearly impossible to determine which post is replying to which if it does not contain the direct line to the next, and often the actual post it is replying to is multiple posts above it. This is why only one thread for each reply should be shown.

image

@DavidBuchanan314
Copy link
Contributor

Nesting depth is now mitigated by #1062, although I would also prefer a flat list layout, or a map indexed by CID. Each entry can still reference replies and parent by CID, allowing a client to reconstruct the tree hierarchy if needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants