Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mention link on profile screen #1286

Closed
myConsciousness opened this issue Aug 26, 2023 · 4 comments
Closed

Mention link on profile screen #1286

myConsciousness opened this issue Aug 26, 2023 · 4 comments
Assignees
Labels
bug Something isn't working x:planned We're on it!

Comments

@myConsciousness
Copy link

myConsciousness commented Aug 26, 2023

Describe the bug

There has been a minor bug in the profile screen for some time.

For example, if you press the Profile menu from the web and go to the Profile screen, the Mention link in the description set in the profile is functional as shown in the following image.

スクリーンショット 2023-08-26 18 05 26

But if you come from a link that was mentions in someone's post, the link is not set in the mentions as shown below.

スクリーンショット 2023-08-26 18 06 12

To Reproduce

Steps to reproduce the behavior:

Web

  1. Set up a Mention link in the Profile description
  2. Go to your profile screen from a post where someone mentions you

Mobile

  1. Set up a Mention link in the Profile description
  2. Go to your profile screen from a post where someone mentions you
  3. Or swipe to update on your profile screen

Expected behavior

In any case, the Mention link in the profile description should be working.

Details

  • App version:
    • 1.47.0

Additional context

@myConsciousness myConsciousness added the bug Something isn't working label Aug 26, 2023
@myConsciousness
Copy link
Author

I haven't checked the code, but it may be that the process of setting the link to the mentions is not working depending on the route taken to the profile screen.

@intrnl
Copy link

intrnl commented Aug 26, 2023

seems to be a dupe of #1223 (comment)
both this and the linked issue talks about mentions not being properly linked inside profile bios, if it pertains to the store not getting updated correctly, then both are talking about the same issue

@myConsciousness
Copy link
Author

@intrnl

I read the Issue you shared, and I'm not sure if it's the same cause. But I imagine it's simply that the process of setting up the Mention link is missing only for certain routes.

@pfrazee pfrazee self-assigned this Aug 28, 2023
@pfrazee pfrazee added the x:planned We're on it! label Aug 28, 2023
@pfrazee
Copy link
Collaborator

pfrazee commented Aug 28, 2023

Yeah this is a dupe issue. You're right that something seems to cause it depending on the route taken to show the profile; I haven't been able to isolate the cause yet.

@pfrazee pfrazee closed this as completed Aug 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working x:planned We're on it!
Projects
None yet
Development

No branches or pull requests

3 participants