Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

account names with handshake TLDs cannot be resolved in the post composer or search #2517

Open
deceptionagent opened this issue Jan 12, 2024 · 4 comments
Labels
bug Something isn't working x:wontfix This will not be worked on

Comments

@deceptionagent
Copy link

when composing a post, typing "@krystal.swor.ds" does not find the account in the live post composer or result in resolved account reference after posting. attached screenshots show that this is a valid account name and that i can otherwise resolve account names of other people.

i wasn't sure if this was proto or client, so i went client.

platform: iOS, mobile web (safari), desktop web

i do not have an android device on which to test.

image
image
image

@deceptionagent deceptionagent added the bug Something isn't working label Jan 12, 2024
@wtlgo
Copy link

wtlgo commented Jan 12, 2024

This might happen because they didn't confirm their email address. I noticed that this happens to new users I invite, and after they confirm their emails it becomes normal.

@Bossett
Copy link
Contributor

Bossett commented Jan 12, 2024

https://bsky.app/profile/bossett.bsky.social/post/3kispucxmkf2q - tagging the old handle works, even though it was unable to resolve either handle via auto-complete in the composer.

.ds is a Handshake domain (https://porkbun.com/tld/ds), which appears to be valid according to https://plc.directory/did:plc:sonncyo6avfaobajokkmqvm2/log/audit (and no 'invalid.handle' errors); but maybe not resolved within the app/search/etc.?

(Would suggest that the fix is likely to just disallow Handshake, as resolution is not going to be consistent; and the project doesn't have mass adoption. @mary-ext provided a simple fix at https://bsky.app/profile/mary.my.id/post/3kistqnnv4n2q - just use https://data.iana.org/TLD/tlds-alpha-by-domain.txt as the allowlist.)

@deceptionagent deceptionagent changed the title cannot resolve the account name "@krystal.swor.ds" when composing posts account names woth handshake TLDs cannot be resolved in the post composer or search Jan 29, 2024
@deceptionagent deceptionagent changed the title account names woth handshake TLDs cannot be resolved in the post composer or search account names with handshake TLDs cannot be resolved in the post composer or search Jan 29, 2024
@pfrazee
Copy link
Collaborator

pfrazee commented Jan 29, 2024

Oh yeah, we don't support Handshake TLDs. This isn't strictly enforced per-se; it's just that none of the DNS resolution architecture uses it.

@pfrazee pfrazee added the x:wontfix This will not be worked on label Jan 29, 2024
@deceptionagent
Copy link
Author

yeah, now that i know tbis is handshake-related i would agree it ain't a thing you should support. would you like to close, or keep this for disallowing them?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working x:wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

4 participants