Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I think my feedgen app returns posts in JSON which randomly do not get hydrated by bsky.app #2657

Closed
venteto opened this issue Jan 28, 2024 · 6 comments
Labels
bug Something isn't working

Comments

@venteto
Copy link

venteto commented Jan 28, 2024

Describe the bug
I have a benchmark curated user list of the MoMA, Guggenheim and Tate art bots. I made a test feed following the same three accounts, and when I look at both side by side, in my feed I notice random posts are missing which are present in the curated user list.

I look inside my database, and I see those posts did in fact get saved to the database by my firehose indexer. I go to the URL on my site where the feed should be getting served to Bluesky, and I see those posts also appear in the generated JSON.

I've been trying to figure out what I've been doing wrong, but considering the posts are in the JSON response, it would seem that for some reason the issue is not on my end but on the Bluesky consumer end?

To Reproduce

Steps to reproduce the behavior:

  1. Go open my feed and my user list in two windows side by side.
  2. Notice that posts in the user list randomly do not appear in my feed.
  3. Visit my feed generator app URL at Fly.io for this specific feed.
  4. Notice the post ID's of the missing posts are in the JSON output Bluesky should be consuming.

Expected behavior

I expected my feed to have the exact same output as my curated user list, post for post, so my feed could be a drop in replacement for the curated user list.

Screenshots

bsky-json-not-hydrated

bsky-compare

Details

I'm just looking at the web app version of Bluesky in desktop Firefox.

Additional context

My test app repo

@venteto venteto added the bug Something isn't working label Jan 28, 2024
@dolciss
Copy link
Contributor

dolciss commented Jan 28, 2024

Have you set Content Languages to English?
It seems that the Post is not being displayed due to language judgments as in #1960

I have checked and all applicable Posts are language detected by lande because post.record.langs is not set.
Currently, to avoid this, either unset Content Language or set post.record.langs correctly

at://did:plc:z5pxuiispc5yacvofktometn/app.bsky.feed.post/3kjzbhr3yw72o
Alan Cote, Distant Warmth, 1978

-> lande detected 'eng'

at://did:plc:pa2epocjfar2fzz4symzmb5t/app.bsky.feed.post/3kjzaoqu2v52r
Akram Zaatari, Anonymous. Studio Shehrazade, Saida, Lebanon, 1960s. Hashem el Madani, 2007

-> lande detected 'cat'

at://did:plc:jx26hj3zymmn53cfjetkmwry/app.bsky.feed.post/3kjz7ol4jm22f
Korn by Gerhard Richter, 1982

-> lande detected 'eng'

at://did:plc:z5pxuiispc5yacvofktometn/app.bsky.feed.post/3kjz6tqoasa23
Mordecai Ardon, Amulet for a Yellow Landscape, 1966

-> lande detected 'cat'

at://did:plc:pa2epocjfar2fzz4symzmb5t/app.bsky.feed.post/3kjz6byz2ne2a
Dieter Roth, Hemdenstein, 1971

-> lande detected 'deu'

at://did:plc:pa2epocjfar2fzz4symzmb5t/app.bsky.feed.post/3kjz3etd2ls2m
William Holman Hunt, Claudio and Isabella, 1850

-> lande detected 'cat'

at://did:plc:pa2epocjfar2fzz4symzmb5t/app.bsky.feed.post/3kjz23sxq232l
Paula Rego, Drawing for ‘The Dance’, 1988

-> lande detected 'eng'

@MarshalX
Copy link

MarshalX commented Jan 28, 2024

@dolciss awesome answer!

i opened the deployed feed from the issue in ff and got these headers:
image

i cant see here content-lang header. do i miss something? body doesnt contain any lang field too

upd. do you mean account settings at https://bsky.app/settings/language?

set "Content Languages" to none

image

@dolciss
Copy link
Contributor

dolciss commented Jan 28, 2024

do you mean account settings at https://bsky.app/settings/language?

Opps, yes, the Content Language I am referring to is in the settings, not the header.
I have unchecked all languages, so the corresponding Post is also shown.
image

@MarshalX
Copy link

verified. yes, this is why it got filtered!

@venteto
Copy link
Author

venteto commented Jan 28, 2024

I don't even recall touching this setting in the client app, but changing it seems to solve my problem. Thanks!!

Interesting that this setting only affects feeds, but not curated user lists.

@venteto venteto closed this as completed Jan 28, 2024
@surfdude29
Copy link
Contributor

I don't even recall touching this setting in the client app

I think it's set by default when you create your account

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants