Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The replies indicator line is too low contrast to discern #2976

Open
Bossett opened this issue Feb 23, 2024 · 7 comments
Open

The replies indicator line is too low contrast to discern #2976

Bossett opened this issue Feb 23, 2024 · 7 comments
Labels
bug Something isn't working

Comments

@Bossett
Copy link
Contributor

Bossett commented Feb 23, 2024

Describe the bug

On iOS (at least), the line connecting profile picture to indicate a reply is too low contrast to reasonably discern:

image

To Reproduce

Steps to reproduce the behavior:

  1. Reply to a post
  2. Navigate to post on iOS, observe line

Expected behavior

Contrast should be higher, or indicator should be thicker/redesigned

Details

  • Platform: iOS (maybe other mobile; very screen dependent)
  • Platform version:
  • App version: 1.68.0
@Bossett Bossett added the bug Something isn't working label Feb 23, 2024
@haileyok
Copy link
Contributor

I can't actually tell. Is this dim or dark? We're about to fix up dim right now and hopefully get it released soon, but if this is dark we might need to look at that as well.

@Bossett
Copy link
Contributor Author

Bossett commented Feb 23, 2024

The screenshot is from dim. Dark is a little better:

Dark:
image

Dim:
image

On the PC screen I can clearly tell those are different themes, but on the phone screen (iPhone 14 Pro) they are almost indistinguishable.

@jghiloni
Copy link

This is a biggish a11y issue

@haileyok
Copy link
Contributor

We made some changes to contrasts in this upcoming release, going to leave this open though for feedback after 1.69 comes out, so feel free to respond or @ when it does.

@Bossett
Copy link
Contributor Author

Bossett commented Feb 27, 2024

This is much better for me in 1.69 - my concern in raising the ticket has been addressed.

Not sure if anyone is able to comment on the accessibility aspect?

@haileyok
Copy link
Contributor

@jghiloni Pinging you since you had mentioned it. Curious if you have any thoughts on whether this is better and/or if there are any additional changes that could help?

@jghiloni
Copy link

Orders of magnitude better, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants