Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accessibility bug: options menu aria-label is sub-optimal #6311

Open
SleeplessByte opened this issue Nov 13, 2024 · 0 comments
Open

Accessibility bug: options menu aria-label is sub-optimal #6311

SleeplessByte opened this issue Nov 13, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@SleeplessByte
Copy link

Steps to Reproduce

  1. Go to https://bsky.app
  2. Use a screenreader and tab onto a more options button for a post
clickable  Open post options menu  menu button  collapsed  subMenu    link  

And then the first time you activate a menu item (arrow up/down)

Open post options menu menu item <whatever the item is>

When a <button> has an aria-label, it should not have the word button inside the label, as the screenreader will add that for us (this does not have that), but in the same way, when there is aria-haspopup="menu", the fact that there is a menu will be added. Together with aria-expanded="false", there is ample information to detect that clicking this button will open the post options menu.

A better label would be:

Post options

The text would then be:

clickable  Post options  menu button  collapsed  subMenu    link  

and

Post options menu item <whatever the item is>

Attachments

No response

What platform(s) does this occur on?

Web (Desktop), Web (Mobile)

Device Info

Not relevant

What version of the app are you using?

Web

Additional Information

I strongly recommend there is a guidance document or a review step that checks these.

@SleeplessByte SleeplessByte added the bug Something isn't working label Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant