Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

punycode failures, you can't @ a punycode handle, and handles render incorrectly #6354

Open
blowdart opened this issue Nov 15, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@blowdart
Copy link

Steps to Reproduce

Someone has registered a handle with a punycode domain -

bsky-bsky-bsky.p-256.移动 which, correctly you are mapping underneath to bsky-bsky-bsky.p-256.xn--6frz82g

However, a couple of problems occur in the web app.

  1. View that profile (https://bsky.app/profile/bsky-bsky-bsky.p-256.xn--6frz82g)
  2. Now @ them, either via the compose button on their profile, or by following them and then using the search ahead (which works)
  3. Add some more text
  4. Create the post
  5. Marvel as you get a post but the @ is not active. There are no underlying facets in the post record (e.g. at://did:plc:hfgp6pj3akhqxntgqwramlbg/app.bsky.feed.post/3laxkj2ww422c)
  6. You're displaying the punycode handle on their profile page and search ahead. You should probably convert it back.

image

Attachments

No response

What platform(s) does this occur on?

iOS, Web (Desktop)

Device Info

No response

What version of the app are you using?

Build version: 1.93.0; Bundle info: 7731136 (prod); Bundle date: 24110818; Platform: web

Additional Information

No response

@blowdart blowdart added the bug Something isn't working label Nov 15, 2024
@pelifix
Copy link

pelifix commented Nov 16, 2024

I can confirm, same problem here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants