Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notification when someone likes your feed is unclear #968

Closed
Emma-Fuller opened this issue Jul 4, 2023 · 3 comments · Fixed by #980
Closed

Notification when someone likes your feed is unclear #968

Emma-Fuller opened this issue Jul 4, 2023 · 3 comments · Fixed by #980
Assignees
Labels
bug Something isn't working x:planned We're on it!

Comments

@Emma-Fuller
Copy link
Contributor

Describe the bug

When someone likes your feed, the notification shows the text "[User] liked your post"
This is unclear since it does not distinguish that it is a feed being liked and not a post, nor does it show which feed was liked

To Reproduce

Steps to reproduce the behavior:

  1. Create a feed or use a feed you already own
  2. Like the feed so you get a notification

Expected behavior

A message along the lines of "[User] liked feed [Feed Name]"

Screenshots

image

Details

  • Platform: web (though id imagine it affects all)
  • Platform version: Most recent
  • App version: Most recent

Additional context

Additional context provided here
https://bsky.app/profile/clarabelle.xyz/post/3jzplhdm2mu2v

@Emma-Fuller Emma-Fuller added the bug Something isn't working label Jul 4, 2023
@Emma-Fuller
Copy link
Contributor Author

Just noticed clicking the link leads to a broken page, so definitely a bug

image

@pfrazee pfrazee added the x:planned We're on it! label Jul 5, 2023
@pfrazee
Copy link
Collaborator

pfrazee commented Jul 5, 2023

Oooh yep. Thanks for the report. @ansh can I hand this one to you?

@mackuba
Copy link

mackuba commented Jul 7, 2023

Oh nice, thanks for this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working x:planned We're on it!
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants