Move FollowButton to ProfileHeader #1842
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Web
web-demo.mov
App
app-demo.mov
In the current state, the
ProfileHeader
component uses customTouchableOpacity
components to display the Follow/Unfollow Action button, despite the fact that we already have a pre-existingFollowButton
component in the app.Suggested follows icon is not visible in dark mode. It is being displayed as white circle when
showSuggestFollows
is set totrue
.Furthermore, when the follow/unfollow action is initiated, the button interactions remain active, and there is no loading indicator displayed which may confuse the user.
To address these issues, we should:
FollowButton
component within theProfileHeader
.Button
component by introducingStartIcon
andEndIcon
props, enabling the rendering of additional icons such as a plus sign (+) or a checkmark (✓) alongside the follow/unfollow text inFollowButton
component. By usingButton
component, we eliminate the need of controlling loading state to disable interactions on the button since it is already being internally handled by theButton
component itself.App demo after changes
app-fixed.mov
Web demo after changes
web-fixed.mov