Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move FollowButton to ProfileHeader #1842

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

tarikfp
Copy link
Contributor

@tarikfp tarikfp commented Nov 8, 2023

Web

web-demo.mov

App

app-demo.mov
  • In the current state, the ProfileHeader component uses custom TouchableOpacity components to display the Follow/Unfollow Action button, despite the fact that we already have a pre-existing FollowButton component in the app.

  • Suggested follows icon is not visible in dark mode. It is being displayed as white circle when showSuggestFollows is set to true.

  • Furthermore, when the follow/unfollow action is initiated, the button interactions remain active, and there is no loading indicator displayed which may confuse the user.

To address these issues, we should:

  • Utilize the existing FollowButton component within the ProfileHeader.
  • Changing Suggested follows icon's color to correct one.
  • Enhance the Button component by introducing StartIcon and EndIcon props, enabling the rendering of additional icons such as a plus sign (+) or a checkmark (✓) alongside the follow/unfollow text in FollowButton component. By using Button component, we eliminate the need of controlling loading state to disable interactions on the button since it is already being internally handled by the Button component itself.

App demo after changes

app-fixed.mov

Web demo after changes

web-fixed.mov

- Button component with optional start/end icon elements
- Suggested follows icon's dark mode color adjusted in ProfileHeader
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant