CLI arguments for 'start-re-manager' to set logging verbosity #135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmgav
changed the title
mrakitin
reviewed
Mar 16, 2021
| @@ -1521,8 +1522,7 @@ def run(self): | |||
| Overrides the `run()` function of the `multiprocessing.Process` class. Called | |||
| by the `start` method. | |||
| """ | |||
|
|
|||
| logging.basicConfig(level=logging.WARNING) | |||
| logging.basicConfig(level=max(logging.WARNING, self._log_level)) | |||
There was a problem hiding this comment.
What is the intention here? E.g. if self._log_level is INFO (=20), the set level will be WARNING (=30). The description says the default is INFO.
There was a problem hiding this comment.
This would be logging level for other packages except bluesky_queueserver for which logging is not set explicitly. Typically it is undesirable to get debug/info logging from all packages in any circumstances. So here I limit logging level to WARNING or higher.
Co-authored-by: Maksim Rakitin <mrakitin@users.noreply.github.com>
mrakitin
reviewed
Mar 16, 2021
Co-authored-by: Maksim Rakitin <mrakitin@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The set of CLI parameters was added to
start-re-managerthat allow to modify verbosity of logging output. Currently logging can only be sent to stdout/stderr. By default, RE Manager will display log messages starting fromloglevel=INFO. The log includes warnings, errors, brief messages with information about the state of the manager and worker processes and executed steps. This behavior may be modified by callingstart-re-managerwith the following mutually exclusive parameters:--verboseprints all logging messages includingDEBUGmessages. In addition to short messages indicating the executed steps, the output will display contents of all received/send messages, submitted plans etc. Verbose output may be useful for debugging purposes, but may slow down the system if the plan queue, history or the lists of plans/devices become long.--quietprints only warning and error message. Output is insufficient to monitor plan execution.--silentdisables logging.Resolves the issue #130