Include resource, datum in filler_state. #185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `filler_state` is a threadsafe way to side-band information into "coersion" functions that, for example, return the data as a dask array. We added this so that the functions could have access to `shape` via the descriptor. In some cases we also need access to the resource to do that successfully. In the future, when we support variable-length chunks, we may also want access to the datum. Prototyped and interactively tested against FXI data in https://gist.github.com/danielballan/b4fccac29cd77e7bdfd93eba775d9b81
|
This whole feature feels like a giant hack, so I am slightly reluctant to extend it, but this PR constitutes a small, natural, and somewhat anticipated extension. When we rethink and simplify how bluesky handles external data (see #156) this mechanism will likely not be needed, but in the short term is a very helpful escape hatch for making data readable. |
cryos
approved these changes
Aug 29, 2020
There was a problem hiding this comment.
This seems reasonable to me, but I know you and @tacaswell have more background. It will be great to get at my angles ;-)
tacaswell
approved these changes
Sep 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
filler_stateis a threadsafe way to side-band information into"coersion" functions that, for example, return the data as a dask array.
We added this so that the functions could have access to
shapevia thedescriptor. In some cases we also need access to the resource to do that
successfully. In the future, when we support variable-length chunks, we
may also want access to the datum.
Prototyped and interactively tested against FXI data in
https://gist.github.com/danielballan/b4fccac29cd77e7bdfd93eba775d9b81