-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change motor internals to better match ophyd #42
Comments
I think I might have changed my mind that we need to keep internal signal names the same. It's only a minor change from ophyd |
Discussed offline, attribute names should match as much as possible |
It would also be good to add the fields we're missing in DiamondLightSource/hyperion#1235 |
DominicOram
added a commit
that referenced
this issue
Apr 5, 2024
DominicOram
added a commit
that referenced
this issue
Apr 5, 2024
DominicOram
added a commit
that referenced
this issue
Apr 5, 2024
DominicOram
added a commit
that referenced
this issue
Apr 8, 2024
DominicOram
added a commit
that referenced
this issue
Apr 8, 2024
DominicOram
added a commit
that referenced
this issue
Apr 8, 2024
DominicOram
added a commit
that referenced
this issue
Apr 15, 2024
Co-authored-by: Tom C (DLS) <101418278+coretl@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
To ease in migration it would be good if the underlying signals in
Motor
had the same name asEpicsMotor
. For example,user_readback
inEpicsMotor
isreadback
inMotor
. We should go through and try and keep consistency unless there is a good reason to change the name.Additionally, there are a number of parameters that are not exposed:
The text was updated successfully, but these errors were encountered: