Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change motor internals to better match ophyd #42

Closed
DominicOram opened this issue Oct 29, 2023 · 3 comments · Fixed by #174
Closed

Change motor internals to better match ophyd #42

DominicOram opened this issue Oct 29, 2023 · 3 comments · Fixed by #174
Assignees

Comments

@DominicOram
Copy link
Contributor

DominicOram commented Oct 29, 2023

To ease in migration it would be good if the underlying signals in Motor had the same name as EpicsMotor. For example, user_readback in EpicsMotor is readback in Motor. We should go through and try and keep consistency unless there is a good reason to change the name.

Additionally, there are a number of parameters that are not exposed:

@DominicOram
Copy link
Contributor Author

I think I might have changed my mind that we need to keep internal signal names the same. It's only a minor change from ophyd

DominicOram added a commit that referenced this issue Nov 1, 2023
@DominicOram DominicOram self-assigned this Nov 2, 2023
@DominicOram
Copy link
Contributor Author

Discussed offline, attribute names should match as much as possible

@DominicOram
Copy link
Contributor Author

It would also be good to add the fields we're missing in DiamondLightSource/hyperion#1235

DominicOram added a commit that referenced this issue Apr 5, 2024
DominicOram added a commit that referenced this issue Apr 5, 2024
DominicOram added a commit that referenced this issue Apr 8, 2024
DominicOram added a commit that referenced this issue Apr 15, 2024
Co-authored-by: Tom C (DLS) <101418278+coretl@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant