Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tab completion for bash support #67

Merged
merged 2 commits into from
Jul 30, 2024
Merged

Conversation

MHendricks
Copy link
Member

@MHendricks MHendricks commented Aug 25, 2023

Checklist

  • I have read the CONTRIBUTING.md document
  • I formatted my changes with black
  • I linted my changes with flake8
  • I have added documentation regarding my changes where necessary
  • Any pre-existing tests continue to pass
  • Additional tests were made covering my changes

Types of Changes

  • Bugfix (change that fixes an issue)
  • New Feature (change that adds functionality)
  • Documentation Update (if none of the other choices apply)

Proposed Changes

Fixes issues with using click's shell completion including dynamically completing any known URI's.

I've included a pre-compiled completion script that can be added to a user's .bashrc file. I'm not sure if we want to do this, but it seems to be the same on the platforms I've tested with (git bash on windows and ubuntu using WSL).

Note: The alias tab completion doesn't work for --launch in env and activate because it requires resolving the URI first. However --launch is an option and the URI is an argument and click resolves options before arguments.

@MHendricks MHendricks force-pushed the completion branch 2 times, most recently from 9729242 to cc8b244 Compare July 23, 2024 01:47
This includes dynamic URI completion of known URI's and aliases.
Note: Alias complete doesn't work for env/activate. It requires working
around click's default parsing implementation.
@MHendricks MHendricks marked this pull request as ready for review July 30, 2024 17:48
@MHendricks MHendricks merged commit 5e44ff2 into blurstudio:main Jul 30, 2024
27 checks passed
@MHendricks MHendricks deleted the completion branch July 30, 2024 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant