Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't mess with completing-read #84

Closed
bmag opened this issue Feb 21, 2016 · 0 comments
Closed

Don't mess with completing-read #84

bmag opened this issue Feb 21, 2016 · 0 comments
Labels
refactor
Milestone
2.0

Comments

@bmag
Copy link
Owner

bmag commented Feb 21, 2016

We have some clunky abstraction over completing-read, we don't want to mess with it, better to use completing-read as is and just let the completion frameworks take over from there.
This means getting rid of purpose-get-read-function and all the functions that use it (purpose-get-completing-read-function, purpose-get-read-file-name-function).
@bmag bmag added this to the 2.0 milestone Feb 21, 2016
@bmag bmag added the refactor label Feb 21, 2016
wyuenho added a commit to wyuenho/emacs-purpose that referenced this issue May 28, 2018
@wyuenho
Fix bmag#84 remove completing-read' and read-file-name' shims
0078c45
wyuenho added a commit to wyuenho/emacs-purpose that referenced this issue May 28, 2018
@wyuenho
Fix bmag#84 remove completing-read' and read-file-name' shims
749fc98
wyuenho added a commit to wyuenho/emacs-purpose that referenced this issue May 28, 2018
@wyuenho
Fix bmag#84 remove completing-read' and read-file-name' shims
7f334ff
@bmag bmag closed this as completed in ff1ff69 May 31, 2018
wyuenho added a commit to wyuenho/emacs-purpose that referenced this issue May 31, 2018
@wyuenho
Fix bmag#84 remove completing-read' and read-file-name' shims
8702a45
wyuenho added a commit to wyuenho/emacs-purpose that referenced this issue May 31, 2018
@wyuenho
Fix bmag#84 remove completing-read' and read-file-name' shims
710e6df
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
refactor
Projects
None yet
Milestone
2.0
Development

No branches or pull requests
1 participant
@bmag