You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Under next-error-follow-minor-mode, next-error-no-select will override window-purpose's display-buffer-overriding-action. This will result in source buffers not displaying in the purpose-dedicated window for source code in complex window layouts. This fix makes sure next-error works with window-purpose.
According to display-buffer-overriding-action new documentation (since Emacs 26.2), next-error-no-select is using display-buffer-overriding-action as intended, while Purpose is misusing the variable. Reworking Purpose will be a major change (that already started in base-action branch and develop branch), so for now I have no problem with this PR - assuming it doesn't cause other buggy side effects (did you verify that?). Same goes for #168 and #169.
Reworking Purpose will be a major change (that already started in base-action branch and develop branch), so for now I have no problem with this PR - assuming it doesn't cause other buggy side effects (did you verify that?)
Agreed. All of these PRs are fixes I have been using in my init.el for a while now. I haven't had any issues with them.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
wyuenho
force-pushed
the
fix-next-error
branch
from
Under
next-error-follow-minor-mode,next-error-no-selectwill override window-purpose'sdisplay-buffer-overriding-action. This will result in source buffers not displaying in the purpose-dedicated window for source code in complex window layouts. This fix makes surenext-errorworks with window-purpose.