replace exampleopendbi_test.go with several small examples #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmatsuo
force-pushed
the
bmatsuo/replace-opendbi-example
branch
from
6f7583c
to
d196b9f
Compare
This test was the most difficult to replace because it described error conditions to some success. Strict code examples do this less well. The replacement examples seem to do a reasonably good job due to their brevity. Examples include more general enforcement of the idea that DBIs should be held for the duration of an enviornment's use. Reference to flag and errno values in the package was made consistent so that comment text does not use an "lmdb." prefix on names. Closes #2.
bmatsuo
force-pushed
the
bmatsuo/replace-opendbi-example
branch
from
ed94a10
to
98039fa
Compare
bmatsuo
added a commit
that referenced
this pull request
Oct 20, 2015
replace exampleopendbi_test.go with several small examples
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test was the most difficult to replace because it described error
conditions to some success. Strict code examples do this less well.
The replacement examples seem to do a reasonably good job due to their
brevity.
Examples include more general enforcement of the idea that DBIs should
be held for the duration of an enviornment's use.
Closes #2.