Skip to content
This repository has been archived by the owner on Aug 29, 2023. It is now read-only.

fix: Invalid reference returned by AddImage on Windows #37

Merged
merged 1 commit into from
Jun 14, 2021
Merged

fix: Invalid reference returned by AddImage on Windows #37

merged 1 commit into from
Jun 14, 2021

Conversation

bmaupin
Copy link
Owner

@bmaupin bmaupin commented Jun 14, 2021

Closes #19

@bmaupin
Copy link
Owner Author

bmaupin commented Jun 14, 2021

@gonejack As discussed in #20 I split this into a separate PR because it's easier to deal with one change at a time. I rebased off your previous commit so you'll still show up as a contributor.

I also added Windows CI tests to help catch these issues in the future (#33). Thanks for your help!

@bmaupin bmaupin merged commit df79d81 into main Jun 14, 2021
@bmaupin bmaupin deleted the 19-fix-windows-addimage branch June 14, 2021 18:24
@coveralls
Copy link

Coverage Status

Coverage remained the same at 82.436% when pulling 960a922 on 19-fix-windows-addimage into 8ccc64a on main.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Invalid reference returned by AddImage on Windows
3 participants
@bmaupin @coveralls @gonejack