Fixed missing method bug caused by hash collisions. #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The hashCode methods used by MethodInfo and FieldInfo just used the signature field to generate a hashCode. The signature field is only available when the method/field involves generic types and was otherwise set to the method/field name. Therefore, when there were no generics and overloaded method names, only one would be stored. Also, in cases where generics are used, multiple methods could have the same signature (as the method name is not included). Solution is to use the method name plus the method descriptor, which should be unique. Also changed signature to be the empty string by default instead of the method/field name.
bmc
added a commit
that referenced
this pull request
May 31, 2013
Fixed missing method bug caused by hash collisions.
|
Merged. Thanks. Will release a new version shortly. |
|
If you want to hold off on the new release, I have another small improvement that I'll submit soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.