Creating a default for make_cost_matrix #11
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe the make_cost_matrix function is more complex than it should. The most obvious solution would be to simply negate the profit matrix, but I'm not sure if the method expects a strictly positive matrix. We can then translate the negated matrix values enough to ensure positivity, by translating as much as the maximum. That is,
This solution works for all numeric types, thus not requiring one to specify a lambda function.