Fixed background state #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pinging back on this -- looks like we have enough issues to push out a point release in the immediate future. Any interest in finishing this one up so we can include it? |
bmcfee
requested changes
Mar 1, 2017
muda/deformers/background.py
Outdated
|
|
||
| with psf.SoundFile(str(filename), mode='r') as soundf: | ||
|
|
||
| n_target = int(np.ceil(n_samples * soundf.samplerate / sr)) |
There was a problem hiding this comment.
sr should be explicitly cast here as float(sr) to ensure floating-point division in legacy python
|
Hey, yeah, I will make sure I get to this soon. It won't happen today, but probably tomorrow. |
|
Yo, added some tests. |
Closed
|
Thanks! This looks like you merged master though. Could you rebase instead to keep the commit log clean? |
Added start and stop indices of noise source files to background state
mcartwright
force-pushed
the
fix-background-state
branch
from
b84bbff
to
b411078
Compare
|
Cleaned up history |
bmcfee
approved these changes
Mar 4, 2017
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added start and stop indices of the noise source files to background state. This is in response to Issue #39