Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding direct connect client #135

Merged
merged 6 commits into from
Oct 19, 2018
Merged

Adding direct connect client #135

merged 6 commits into from
Oct 19, 2018

Conversation

kellrott
Copy link
Member

Re-do of #131, but now the code is:

@kellrott kellrott mentioned this pull request Aug 29, 2018
@adamstruck
Copy link
Contributor

I'd like to have a better idea of how this impacts performance before we merge this

@kellrott
Copy link
Member Author

kellrott commented Sep 7, 2018

Using

time curl -d '{"query": [{"v": []}, {"limit": 1000000}]}' http://localhost/v1/graph/bmeg-test/query > /dev/null  

The original branch: 1m25.143s
New branch: 1m3.491s

As a note, the GRIP grpc based client does the same query in 0m41.103s

@adamstruck
Copy link
Contributor

adamstruck commented Sep 7, 2018

Please add HTTP auth test.

@adamstruck adamstruck merged commit b5844fa into master Oct 19, 2018
@kellrott kellrott deleted the direct-connect-new branch October 20, 2018 05:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants