Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gripql/python: passing None to in_(), out(), both(), etc. should have no effect #148

Merged
merged 2 commits into from
Sep 25, 2018
Merged

gripql/python: passing None to in_(), out(), both(), etc. should have no effect #148

merged 2 commits into from
Sep 25, 2018

Conversation

adamstruck
Copy link
Contributor

This makes it so that the following two queries are equivalent:

query.V().where(gripql.eq("_label", "Aliquot")).in_().count()

query.V().where(gripql.eq("_label", "Aliquot")).in_(None).count()

@adamstruck adamstruck changed the title gripql/python: passing None to methods such as in_(), out(), both() has no effect gripql/python: passing None to in_(), out(), both(), etc. should have no effect Sep 25, 2018
@adamstruck adamstruck merged commit 576bb48 into master Sep 25, 2018
@adamstruck adamstruck deleted the gripql-python-none-bugfix branch October 5, 2018 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kellrott kellrott kellrott approved these changes

@bwalsh bwalsh Awaiting requested review from bwalsh

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adamstruck @kellrott