Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decode results before loading json. #159

Merged
merged 1 commit into from
Oct 10, 2018

Conversation

pagreene
Copy link
Contributor

@pagreene pagreene commented Oct 9, 2018

This is a simple but effective (in the cases I have tested) method to allow python 3.5-3.6 compatibility, a la #158.

@kellrott
Copy link
Member

kellrott commented Oct 9, 2018

@adamstruck which python versions is our travis build testing against?

@adamstruck
Copy link
Contributor

@kellrott we are testing against whatever version of python Travis is providing. We definitely need to improve our testing around the python / javascript based clients.

@pagreene
Copy link
Contributor Author

pagreene commented Oct 9, 2018

You can specify both/either/any version of python in the travis yaml. For https://github.com/sorgerlab/indra, for example, we test on both 2.7 and 3.5.

@adamstruck
Copy link
Contributor

Thanks for the contribution @pagreene

@kellrott writing unit tests for the python gripql and creating a testing matrix of python versions can be tracked in #160

@adamstruck adamstruck merged commit ca7b02c into bmeg:master Oct 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants