Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provide a schema file at runtime; post a schema definition to the server #172

Merged
merged 17 commits into from
Jan 5, 2019

Conversation

adamstruck
Copy link
Contributor

@adamstruck adamstruck commented Dec 12, 2018

closes #152
closes #176

@kellrott
Copy link
Member

Can we add the inference code as a tool that can be called on data files?

@adamstruck
Copy link
Contributor Author

Building the schema from the data files will take some work. I suggest we add that tool in a future PR.

@adamstruck adamstruck force-pushed the post-schema branch 2 times, most recently from 47800af to a6afda9 Compare December 19, 2018 19:55
@kellrott
Copy link
Member

Currently the PR supports 3 ways of generating a schema (config, post and periodic scan). I think there should be another method, to manually invoke a scan and store the results. This would allow someone to load arbitrary data, do a scan, and tweak the graph, and then load the results.

@kellrott
Copy link
Member

Added #179 to implement requested behavior.

@kellrott
Copy link
Member

The graph list includes the schema, those should probably be filtered out.

grip list

returns

example-graph
example-graph__schema__

@adamstruck
Copy link
Contributor Author

The graph list intentionally includes the schema. Schemas are themselves graphs that can be traversed.

@adamstruck adamstruck merged commit 4880a8b into master Jan 5, 2019
@adamstruck adamstruck deleted the post-schema branch January 16, 2019 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Less verbose schema Schema request in Python client
2 participants