Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

api cleanup: #181

Merged
merged 4 commits into from
Jan 4, 2019
Merged

api cleanup: #181

merged 4 commits into from
Jan 4, 2019

Conversation

adamstruck
Copy link
Contributor

  • removed dedicated aggregation endpoint
  • ListIndices and ListGraphs are no longer streaming endpoints
  • adds a ListLabels endpoint
    • this required indexing edges by label in the KVStore

@kellrott
Copy link
Member

kellrott commented Jan 2, 2019

Have you done any testing to see the speed difference between the mongo queries generated using the specialized aggregation endpoint and the more generic one in this PR? Does it slow down per-label aggregations?

@adamstruck
Copy link
Contributor Author

I haven't tested it, but for mongo it shouldn't make too much of a difference since under the both use the mono pipeline engine. Elasticsearch aggregation performance will be impacted by this change.

@kellrott
Copy link
Member

kellrott commented Jan 4, 2019

👍

@adamstruck adamstruck merged commit 9f5754d into master Jan 4, 2019
@adamstruck adamstruck deleted the api-cleanup branch January 16, 2019 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants