Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/schema: add exclude labels flag to schema scanner #193

Merged
merged 2 commits into from
Mar 1, 2019

Conversation

adamstruck
Copy link
Contributor

@adamstruck adamstruck commented Feb 13, 2019

depends on #194

@kellrott
Copy link
Member

The string based field negation (O.query().V("vertex1").fields("-symbol") seems like a new pattern in the JSON path that we haven't used before or may not be needed anywhere else. I don't have a better idea (using something like gripql.neq seems weird as well), but it seems a bit of an exception to regular behavior.

@adamstruck
Copy link
Contributor Author

It is a new pattern specific to this method only. I thought that this was fairly standard syntax for field selection / negation, but am open to alternatives. We could base this off the project method from mongo: O.query().V("vertex1").fields({"symbol": 0}) and O.query().V("vertex1").fields({"symbol": 1})

@kellrott
Copy link
Member

kellrott commented Mar 1, 2019

I guess we can test out the string based negation, and change it later if it isn't working for us.
👍

@adamstruck adamstruck mentioned this pull request Mar 1, 2019
1 task
@adamstruck adamstruck merged commit eadea2a into master Mar 1, 2019
@adamstruck adamstruck deleted the schema-sample-cli branch March 27, 2019 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants