Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates golangci-lint to v1.18.0 #219

Merged
merged 3 commits into from
Oct 11, 2019
Merged

Updates golangci-lint to v1.18.0 #219

merged 3 commits into from
Oct 11, 2019

Conversation

bwalsh
Copy link
Collaborator

@bwalsh bwalsh commented Oct 10, 2019

This PR:

  • updates lint to address invalid pseudo-version: does not match version-control timestamp error

@adamstruck
Copy link
Contributor

The Makefile needs to be updated as well: https://github.com/bmeg/grip/blob/master/Makefile#L84

@kellrott
Copy link
Member

kellrott commented Oct 11, 2019

It looks like the only thing blocking this is a misspelling issue the linter started catching in a file not touched by this PR.

@kellrott
Copy link
Member

👍

@kellrott kellrott merged commit 63f9631 into master Oct 11, 2019
@kellrott kellrott deleted the lint-update branch October 6, 2020 05:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants