Adding update option to graph edit methods #45
Conversation
|
|
||
| def test_update(O): | ||
| errors = [] | ||
| #print O.query().addV("vertex1").property("field1", {"test" : 1, "value" : False}).render() |
| if elem.Update { | ||
| o := server.engine.GetVertex(elem.Graph, id) | ||
| if o != nil { | ||
| for k, v := range o.Data.Fields { |
There was a problem hiding this comment.
I think it's possible that o.Data is nil, which would panic.
| if o != nil { | ||
| for k, v := range o.Data.Fields { | ||
| if _, ok := elem.Vertex.Data.Fields[k]; !ok { | ||
| elem.Vertex.Data.Fields[k] = v |
There was a problem hiding this comment.
These wouldn't recursively update fields, right?
There was a problem hiding this comment.
Yes, merging only occurs at the top level.
Suggested behavior?
There was a problem hiding this comment.
I guess that's ok. Please add some comments in the python library and proto description to describe that behavior.
| url = self.url + "/" + self.name + "/vertex" | ||
| if update: | ||
| url += "?update=true" | ||
| print url |
There was a problem hiding this comment.
Remove the debug line.
Also, why is this using a URL parameter? Shouldn't it be part of the request document?
| response = urllib2.urlopen(request) | ||
| result = response.read() | ||
| return json.loads(result) | ||
|
|
||
| def updateVertex(self, id, label, prop={}): |
There was a problem hiding this comment.
Missing corresponding updateEdge and addEdge(update=True)
|
Needs tests. |
|
@adamstruck refactor and resubmit? |
|
When this comes back up, it'll be easier to re-write at this point |
Now, when doing an AddVertex or AddEdge, there is a
updateoption that will check to see if the gid exists, and merges fields from the data struct before replacing in the graph. Only fields not in the new message are merged in.