Devel #1
Closed
Devel #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bminer
requested changes
Jul 2, 2021
.vscode/launch.json
Outdated
| // Hover to view descriptions of existing attributes. | ||
| // For more information, visit: https://go.microsoft.com/fwlink/?linkid=830387 | ||
| "version": "0.2.0", | ||
| "configurations": [ |
benchmark_test.go
Outdated
| var jsonData []byte | ||
| var gobData bytes.Buffer | ||
| var msgPackData []byte | ||
| var xmlData *bytes.Buffer = &bytes.Buffer{} |
There was a problem hiding this comment.
For consistency, change to var xmlData bytes.Buffer and adjust other code accordingly
benchmark_test.go
Outdated
|
|
||
| // SchemaSchema() is here so we can only create the schemer schema once | ||
| // and then reuse it over and over | ||
| func createSchemerSchema() { |
There was a problem hiding this comment.
Unnecessary abstraction: Function is used exactly once and only contains one line of code.
benchmark_test.go
Outdated
|
|
||
| func BenchmarkSchemerEncodeOnly(b *testing.B) { | ||
|
|
||
| createSchemerSchema() |
There was a problem hiding this comment.
The time to create the schema is included in the benchmark! Per the Go docs, use b.ResetTimer()
benchmark_test.go
Outdated
|
|
||
| func schemerEncoder() int { | ||
|
|
||
| schemerCounter++ |
There was a problem hiding this comment.
Instead of using this counter, clear the Buffer beforehand.
fixedobject.go
Outdated
|
|
||
| // The most signifiant bit indicates whether or not the type is nullable | ||
| if s.SchemaOptions.Nullable { | ||
| schemaBytes[0] |= 128 |
fixedobject.go
Outdated
| for i := 0; i < len(s.Fields); i++ { | ||
|
|
||
| f := v.Field(i) | ||
| err := s.Fields[i].Schema.Encode(w, f.Interface()) |
There was a problem hiding this comment.
One thing to note here is that we don't have a function EncodeValue(). (We have DecodeValue() only)
fixedobject.go
Outdated
| return nil | ||
| } | ||
|
|
||
| var CacheMap map[string]string |
fixedobject.go
Outdated
| // and see if there is anywhere we can put them | ||
| for i := 0; i < len(s.Fields); i++ { | ||
|
|
||
| Foundmatch := false |
fixedobject.go
Outdated
|
|
||
| var ignoreMe interface{} | ||
| /* | ||
| if stringToMatch == "String1" { |
There was a problem hiding this comment.
Please clean up old comments where appropriate
Added TODO comments for code review Misc. refactoring
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please merge entire development branch into main.