Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for PHP 8 #256

Merged
merged 1 commit into from
Nov 26, 2020
Merged

Add support for PHP 8 #256

merged 1 commit into from
Nov 26, 2020

Conversation

villfa
Copy link
Collaborator

@villfa villfa commented Oct 29, 2020

Closes #229

@codecov
Copy link

codecov bot commented Oct 29, 2020

Codecov Report

Merging #256 (461a3e6) into master (5d9498b) will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #256      +/-   ##
============================================
- Coverage     96.15%   96.14%   -0.01%     
  Complexity      176      176              
============================================
  Files            24       24              
  Lines           442      441       -1     
============================================
- Hits            425      424       -1     
  Misses           17       17              
Impacted Files Coverage Δ Complexity Δ
src/Result/HighestScores.php 100.00% <ø> (ø) 11.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5d9498b...461a3e6. Read the comment docs.

@villfa
Copy link
Collaborator Author

villfa commented Oct 31, 2020

The build fails because of a problem with phpunit-bridge. See symfony/symfony#38921

@villfa villfa merged commit 1014d44 into bmitch:master Nov 26, 2020
@villfa villfa deleted the feat/php8 branch January 22, 2021 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support PHP-8
1 participant