Fix the removed programs list being empty #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is the same as PR #57 but this time my local codebase is where it should be. |
|
I see nemchik referenced this; is there a consensus on which method is preferred? |
|
In this case, ERRORLEVEL makes 2 lines of code, but it's readable. Using redirection would allow one line of code (or two) but may be less readable. I've never liked using ERRORLEVEL out of personal preference. |
|
It doesn't make a difference to me either way, it just means that someone will have to do the work to ensure that every instance gets changed across all files (and I'm sure there's quite a few of them!) |
|
Merged. |
vocatus
added a commit
that referenced
this pull request
Jan 4, 2016
Fix for removed program list being empty if no programs removed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The IF command that ran that inserts the line into the removed program list if it was empty was flawed. The FC program sets an environment variable of ERRORLEVEL with a value of 0 if there's no difference. The IF check used !ERRORLEVEL! instead of %ERRORLEVEL%, which caused it to not execute. You may want to check your other comparisons.