Add failsafe for drives that can't be read #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See issue #59.
|
Just wanted to link this here because I see your use of ERRORLEVEL and it may be related to the discussion. |
|
The only reason I did it with ERRORLEVEL is that Vocatus likes to maintain a consistent coding style across all of Tron and he will reject pull requests that are not in line with his style. If he or you wishes to rewrite it to make it work better then my code can be updated as well once the PR is merged. |
|
Good fix, thanks. |
vocatus
added a commit
that referenced
this pull request
Jan 4, 2016
Add failsafe for drives that can't be read
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some rare cases, drive information cannot be automatically read by smartctl, as is the case with issue #59. This adds a failsafe that errs on the side of caution in case this drive actually is an SSD.