Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace all prints with SCout messages #57

Closed
holzkohlengrill opened this issue May 12, 2020 · 3 comments
Closed

Replace all prints with SCout messages #57

holzkohlengrill opened this issue May 12, 2020 · 3 comments
Assignees
@DariaPigasova
Labels
bug Something isn't working emma-delta Related to Emma deltas component emma-vis Related to Emma visualiser component good first issue Good for newcomers low prio This issue is less important than others SP: 1
Milestone
3.3

Comments

@holzkohlengrill
Copy link
Collaborator

Description

To insure log level switching we need to remove all print()s and replace it with SCout messages.
Where really needed (i.e. for file presentation -> to user) the SCout basic implementation can/should be used.

Everything in genDoc etc. can be ignored.

Expected behaviour

Correct message display according to log levels.
@holzkohlengrill holzkohlengrill added bug Something isn't working good first issue Good for newcomers low prio This issue is less important than others emma-vis Related to Emma visualiser component emma-delta Related to Emma deltas component labels May 12, 2020
@holzkohlengrill holzkohlengrill added this to the 3.3 milestone May 12, 2020
@DariaPigasova
Copy link
Contributor

DariaPigasova commented May 15, 2020 •
edited
Loading

What should we do with prints in functions that are not used?

@holzkohlengrill
Copy link
Collaborator Author

Replace it with SCout messages if appropriate.

@DariaPigasova
Copy link
Contributor

3698cbc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DariaPigasova DariaPigasova

Labels
bug Something isn't working emma-delta Related to Emma deltas component emma-vis Related to Emma visualiser component good first issue Good for newcomers low prio This issue is less important than others SP: 1
Projects
None yet
Milestone
3.3
Development

No branches or pull requests
2 participants
@holzkohlengrill @DariaPigasova