Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Categorisation keywords as Emma dry run #6

Closed
KGergo88 opened this issue Jul 17, 2019 · 1 comment
Closed

Categorisation keywords as Emma dry run #6

KGergo88 opened this issue Jul 17, 2019 · 1 comment
Assignees
@DariaPigasova
Labels
duplicate This issue or pull request already exists emma Related to Emma component enhancement New feature or request SP: 3
Milestone
3.3

Comments

@KGergo88
Copy link
Member

KGergo88 commented Jul 17, 2019 •
edited by holzkohlengrill
Loading

This should be like a "dry run". We need to run Emma in order to get all sections/objects from the map files. Then we auto-generate the categories config file based on the keyword file(s).

Currently .csv files are saved for such a run (which is the default behaviour for a normal run) which is not desired.

For a "keywords-run" no results should be stored.

TODO in: https://github.com/bmwcarit/Emma/blob/master/emma.py#L136 (invalid link: check commit from Jul 2019)
@KGergo88 KGergo88 added the bug Something isn't working label Jul 17, 2019
@holzkohlengrill holzkohlengrill added emma Related to Emma component enhancement New feature or request and removed bug Something isn't working labels Aug 2, 2019
@holzkohlengrill holzkohlengrill added this to the 3.1 milestone Aug 7, 2019
@holzkohlengrill holzkohlengrill removed this from the 3.1 milestone Sep 5, 2019
@holzkohlengrill holzkohlengrill changed the title TODO Comment in emma.py::136 Categorisation keywords as Emma dry run May 29, 2020
@holzkohlengrill holzkohlengrill added this to the 3.3 milestone May 29, 2020
DariaPigasova added a commit that referenced this issue Jun 10, 2020
@DariaPigasova
close #6, added an argument for allowing not to store any standard re…
4fb382e 
…ports
@DariaPigasova DariaPigasova added the duplicate This issue or pull request already exists label Aug 14, 2020
@DariaPigasova
Copy link
Contributor

DariaPigasova commented Aug 14, 2020 •
edited
Loading

Was already implemented

@DariaPigasova DariaPigasova mentioned this issue Aug 14, 2020
Closed
DariaPigasova added a commit that referenced this issue Aug 17, 2020
@DariaPigasova
close #6, added an argument for allowing not to store any standard re…
c91edf4 
…ports
holzkohlengrill added a commit that referenced this issue Oct 12, 2020
@DariaPigasova @holzkohlengrill
close #6, added dry run argument (#70)
2093c4f 
* close #6, added an argument for allowing not to store any standard reports

* close #6, added an argument for allowing not to store any standard reports

* removed unnecessary function argument

Co-authored-by: Marcel Schmalzl <12732886+holzkohlengrill@users.noreply.github.com>
heliocastro pushed a commit that referenced this issue Mar 7, 2022
@DariaPigasova @holzkohlengrill @heliocastro
close #6, added dry run argument (#70)
83ca2ee 
* close #6, added an argument for allowing not to store any standard reports

* close #6, added an argument for allowing not to store any standard reports

* removed unnecessary function argument

Co-authored-by: Marcel Schmalzl <12732886+holzkohlengrill@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DariaPigasova DariaPigasova

Labels
duplicate This issue or pull request already exists emma Related to Emma component enhancement New feature or request SP: 3
Projects
None yet
Milestone
3.3
Development

No branches or pull requests
3 participants
@holzkohlengrill @KGergo88 @DariaPigasova