-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
official Maven release #4
Comments
Sure, I will take care of this. |
I pushed some additional commits for version 0.2.0. Please note that I changed the package name, groupId and artifactId. |
Thanks! Searching maven repo indicates this is not yet deployed there (you changed the artifactId to prepare this I guess :) ?) BTW: via maven search I found this https://github.com/adrianulbona/hmm |
Yes, changing the artifactId was done in preparation for Maven Central. I wasn't aware of this library yet, probably because it was created in 2016. When I did an investigation on HMM libraries last year, I found some libraries but no library with a suitable license (Apache 2.0, BSD or similar) and with support for time-inhomogeneous Markov processes (i.e. with support for different states and transition probabilities at each time step), which is needed for map matching. |
I just published version 0.2.1-SNAPSHOT on a Maven repository that is located on the mvn-repo branch of this GitHub repository. The hmm-lib can now be added as a Maven dependency:
Moreover, the following repository needs to be added to the pom.xml:
Please let me know if this works. Once everything works fine, I will publish the final version 0.2.1 including jars for sources and javadoc. UPDATE: The Maven repository https://raw.github.com/bmwcarit/hmm-lib/mvn-repo/ has been deleted. For snapshots, please use https://raw.github.com/bmwcarit/hmm-lib/mvn-snapshots/ instead (see also README.md). |
Thanks! Hmmh, I'm not 100% sure but potentially we get problems when we release our map matching component to maven central then. See http://central.sonatype.org/pages/requirements.html In addition we discourage the usage of and and instead publish any required components to the Central Repository. This applies for your own components as well as for 3rd party artifacts. |
I'm still trying to get approval for publishing the hmm-lib to the Maven Central repository but this may take one or two more weeks. When I tried to to use the hmm-lib from the github Maven Repository in graphhopper matching-core, I got compilation errors because the method MostLikelySequence.getBrokenTimeStep() was added to the hmm-lib module in graphhopper map-matching. This method is used here. Do you want to create a pull request for this? |
Yes, sure. Will do when I upgrade to the latest hmm-lib version (hopefully next week) |
I've added PR #5 regarding the missing method, also I've added a new branch which uses this 'external' hmm-lib |
For hmm-lib 1.0.0, I changed the GitHub Maven repository location (there will be separate repositories for snapshots and releases). 1.0.0-SNAPSHOT can now be used via Maven as described here. |
I still don't have approval for publishing the hmm-lib to the Maven Central repository, so you should rather assume that this won't happen. @karussell: I would like to remove https://raw.github.com/bmwcarit/hmm-lib/mvn-repo/ with 0.2.1-SNAPSHOT since snapshots are now deployed to https://raw.github.com/bmwcarit/hmm-lib/mvn-snapshots/. Is this OK for you (the external-hmm-lib branch still uses this)? |
Ok, and yes, this removal should be no problem. |
Would be super cool to have the 0.2.0 in maven central to be used from us. For now we are using the cloned repo directly in our repo, which is kind of suboptimal.
The text was updated successfully, but these errors were encountered: