fix: array out-of-bounds issue in _exitMaintenance
#565
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
unclezoro
reviewed
Jun 24, 2024
unclezoro
reviewed
Jun 24, 2024
unclezoro
reviewed
Jun 24, 2024
zzzckck
previously approved these changes
Jun 24, 2024
|
pls open an issue to track the failed UT, better to bring it up. |
NathanBSC
previously approved these changes
Jun 24, 2024
cosinlink
approved these changes
Jun 24, 2024
unclezoro
approved these changes
Jun 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pr is to fix an issue in
_exitMaintenancethat the array index could be out-of-boundsRationale
tell us why we need these changes...
Example
add an example CLI or API response...
Changes
Notable changes: