Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: nil pointer issue (#388) #399

Merged
merged 1 commit into from
Sep 1, 2021
Merged

Conversation

j75689
Copy link
Contributor

@j75689 j75689 commented Aug 31, 2021

Description

Please see #388

Rationale

This issue cause by #59
Now the deadlock issue fix by official ethereum/go-ethereum#22178
So just need to revert #59.

Example

go test -race ./eth/filters/...

ok      github.com/ethereum/go-ethereum/eth/filters     6.639s

Changes

Notable changes:

  • revert commit 3d3f9694a426eafc32640a643b5399a58209da1c

Preflight checks

  • build passed (make build)
  • tests passed (make test)
  • manual transaction test passed

Already reviewed by

N/A

Related issues

#388

@j75689 j75689 changed the title fix: nil pointer when filter was deleted (#388) fix: nil pointer issue (#388) Aug 31, 2021
@j75689 j75689 merged commit 2d2740e into bnb-chain:master Sep 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants