[R4R]eth/protocols/snap, trie: better error-handling (#23657) #582
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
forcodedancing
approved these changes
Nov 24, 2021
yutianwu
approved these changes
Nov 24, 2021
j75689
approved these changes
Nov 24, 2021
j75689
pushed a commit
that referenced
this pull request
Nov 29, 2021
Co-authored-by: Martin Holst Swende <martin@swende.se>
keefel
pushed a commit
to keefel/bsc
that referenced
this pull request
Jun 6, 2022
Co-authored-by: Martin Holst Swende <martin@swende.se>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR cherry-pock the DoS vulnerabilities fixed in go-ethereum v1.10.9.
check issue #583
Rationale
A vulnerable node is susceptible to crash when processing a maliciously crafted message from a peer, via the snap/1 protocol. The crash can be triggered by sending a malicious snap/1 GetTrieNodes package.
More details please check the report and the upstream PR
Example
None
Related issues
ethereum/go-ethereum#23657