[R4R] add timeout for stopping p2p server #643
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
j75689
reviewed
Dec 8, 2021
j75689
reviewed
Dec 8, 2021
yutianwu
force-pushed
the
fix_p2p_stop
branch
2 times, most recently
from
09962cc
to
75130cd
Compare
unclezoro
reviewed
Dec 8, 2021
yutianwu
force-pushed
the
fix_p2p_stop
branch
from
75130cd
to
fe4c9f1
Compare
j75689
approved these changes
Dec 8, 2021
yutianwu
changed the title
|
LGTM |
unclezoro
approved these changes
Dec 10, 2021
forcodedancing
approved these changes
Dec 13, 2021
kyrie-yl
requested review from
kyrie-yl and
KeefeL
and removed request for
KeefeL
KeefeL
approved these changes
Dec 13, 2021
unclezoro
pushed a commit
that referenced
this pull request
Dec 20, 2021
* add timeout for stopping p2p server * extend extension wait time * add unit tests * fix lint issue
unclezoro
pushed a commit
that referenced
this pull request
Dec 20, 2021
* add timeout for stopping p2p server * extend extension wait time * add unit tests * fix lint issue
KeefeL
pushed a commit
to KeefeL/bsc
that referenced
this pull request
Dec 20, 2021
* add timeout for stopping p2p server * extend extension wait time * add unit tests * fix lint issue
This was referenced Jan 26, 2022
Merged
KeefeL
pushed a commit
to KeefeL/bsc
that referenced
this pull request
Jun 6, 2022
* add timeout for stopping p2p server * extend extension wait time * add unit tests * fix lint issue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
For now, when accepting p2p peers in p2p server, we will run
runEthPeerandRunPeerindiffHandlerandsnapHandlerconcurrently, so sometimesrunEthPeerwill hang there for waiting for the signal that it missed before it runninng.This will cause we can not stop the bsc node gracefully, so we add a timeout for stopping p2p server and a timeout for handling p2p peers.
Rationale
When we can not stop the bsc node gracefully, we will see this in the profile:
Changes
Notable changes: