Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[R4R]update some packages' version #959

Merged
merged 2 commits into from
Jun 30, 2022
Merged

Conversation

keefel
Copy link
Contributor

@keefel keefel commented Jun 22, 2022

Description

a. Upgrade the docker version to 1.6.1
b. Upgrade the GoGo protobuf version to v1.3.2

Rationale

a. Libcontainer and Docker Engine before 1.6.1 opens the file-descriptor passed to the pid-1 process before performing the chroot, which allows local users to gain privileges via a symlink attack in an image.

b. An issue was discovered in GoGo Protobuf before 1.3.2. plugin/unmarshal/unmarshal.go lacks certain index validation, aka the "skippy peanut butter" issue.

Example

NA

Changes

Notable changes:

  • update docker and GoGo protobuf package version

@keefel
Copy link
Contributor Author

keefel commented Jun 22, 2022

The GoGo protobuf is used by the tendermint package in our cross-chain module, I have tested this part is fine after upgrading GoGo protobuf to v1.3.2.

@unclezoro unclezoro changed the title update some packages' version [R4R]update some packages' version Jun 23, 2022
@unclezoro unclezoro merged commit 0f3bfa8 into bnb-chain:develop Jun 30, 2022
This was referenced Jul 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants