-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: update dockerfile with a few enhancement #998
Merged
unclezoro
merged 16 commits into
bnb-chain:develop
from
jasonyic:feat/refactor_dockerfile_2
Jul 20, 2022
Merged
feat: update dockerfile with a few enhancement #998
unclezoro
merged 16 commits into
bnb-chain:develop
from
jasonyic:feat/refactor_dockerfile_2
Jul 20, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jason Yi <jasonhk.yi@consensys.net>
Signed-off-by: Jason Yi <jasonhk.yi@consensys.net>
Signed-off-by: Jason Yi <jasonhk.yi@consensys.net>
Signed-off-by: Jason Yi <jasonhk.yi@consensys.net>
Signed-off-by: Jason Yi <jasonhk.yi@consensys.net>
Signed-off-by: Jason Yi <jasonhk.yi@consensys.net>
Signed-off-by: Jason Yi <jasonhk.yi@consensys.net>
Signed-off-by: Jason Yi <jasonhk.yi@consensys.net>
jasonyic
changed the title
Feat/refactor dockerfile 2
feat: refactor dockerfile to use configuration files as sot
Jul 17, 2022
jasonyic
changed the title
feat: refactor dockerfile to use configuration files as sot
feat: refactor dockerfile to use configuration files as ssot
Jul 18, 2022
j75689
reviewed
Jul 18, 2022
jasonyic
changed the title
feat: refactor dockerfile to use configuration files as ssot
feat: refactor dockerfile with a few enhancement
Jul 18, 2022
jasonyic
changed the title
feat: refactor dockerfile with a few enhancement
feat: update dockerfile with a few enhancement
Jul 18, 2022
j75689
reviewed
Jul 18, 2022
j75689
approved these changes
Jul 19, 2022
unclezoro
approved these changes
Jul 19, 2022
brilliant-lx
approved these changes
Jul 19, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
yutianwu
approved these changes
Jul 20, 2022
This was referenced Jul 28, 2022
Merged
acoshift
added a commit
to moonrhythm/bsc
that referenced
this pull request
Feb 14, 2023
This reverts commit 37b7ac7.
acoshift
added a commit
to moonrhythm/bsc
that referenced
this pull request
Apr 10, 2023
This reverts commit 37b7ac7.
acoshift
added a commit
to moonrhythm/bsc
that referenced
this pull request
Apr 17, 2023
This reverts commit 37b7ac7.
acoshift
added a commit
to moonrhythm/bsc
that referenced
this pull request
May 23, 2023
This reverts commit 37b7ac7.
acoshift
added a commit
to moonrhythm/bsc
that referenced
this pull request
Jun 30, 2023
This reverts commit 37b7ac7.
acoshift
added a commit
to moonrhythm/bsc
that referenced
this pull request
Jul 26, 2023
This reverts commit 37b7ac7.
acoshift
added a commit
to moonrhythm/bsc
that referenced
this pull request
Feb 25, 2024
This reverts commit 37b7ac7.
acoshift
added a commit
to moonrhythm/bsc
that referenced
this pull request
Apr 14, 2024
This reverts commit 37b7ac7.
acoshift
added a commit
to moonrhythm/bsc
that referenced
this pull request
Aug 1, 2024
This reverts commit 37b7ac7.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Configuration file should be used as the single source of truth (ssot), and provide an simple and clean way for operation. a few enhancements have been included in this PR:
dockerfile
to use non-root user &tini
for better process handlingETHEREUM
options to overwrite settings in configuration filedocker-compose
file for local testing