Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update dockerfile with a few enhancement #998

Merged
merged 16 commits into from
Jul 20, 2022

Conversation

jasonyic
Copy link
Contributor

@jasonyic jasonyic commented Jul 17, 2022

Configuration file should be used as the single source of truth (ssot), and provide an simple and clean way for operation. a few enhancements have been included in this PR:

  • refactor dockerfile to use non-root user & tini for better process handling
  • add entry point script to auto init genesis file and boot up node
  • support command line ETHEREUM options to overwrite settings in configuration file
  • provide docker-compose file for local testing
  • add README.md

Signed-off-by: Jason Yi <jasonhk.yi@consensys.net>
Signed-off-by: Jason Yi <jasonhk.yi@consensys.net>
Signed-off-by: Jason Yi <jasonhk.yi@consensys.net>
Signed-off-by: Jason Yi <jasonhk.yi@consensys.net>
Signed-off-by: Jason Yi <jasonhk.yi@consensys.net>
Signed-off-by: Jason Yi <jasonhk.yi@consensys.net>
Signed-off-by: Jason Yi <jasonhk.yi@consensys.net>
Signed-off-by: Jason Yi <jasonhk.yi@consensys.net>
Signed-off-by: Jason Yi <jasonhk.yi@consensys.net>
Signed-off-by: Jason Yi <jasonhk.yi@consensys.net>
@jasonyic jasonyic changed the title Feat/refactor dockerfile 2 feat: refactor dockerfile to use configuration files as sot Jul 17, 2022
@jasonyic jasonyic changed the title feat: refactor dockerfile to use configuration files as sot feat: refactor dockerfile to use configuration files as ssot Jul 18, 2022
Dockerfile Outdated Show resolved Hide resolved
@jasonyic jasonyic changed the title feat: refactor dockerfile to use configuration files as ssot feat: refactor dockerfile with a few enhancement Jul 18, 2022
@jasonyic jasonyic requested a review from j75689 July 18, 2022 08:44
@jasonyic jasonyic marked this pull request as ready for review July 18, 2022 08:45
@jasonyic jasonyic changed the title feat: refactor dockerfile with a few enhancement feat: update dockerfile with a few enhancement Jul 18, 2022
Dockerfile Outdated Show resolved Hide resolved
@jasonyic jasonyic requested a review from j75689 July 18, 2022 11:00
Copy link
Collaborator

@brilliant-lx brilliant-lx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@unclezoro unclezoro merged commit 37b7ac7 into bnb-chain:develop Jul 20, 2022
This was referenced Jul 28, 2022
acoshift added a commit to moonrhythm/bsc that referenced this pull request Feb 14, 2023
acoshift added a commit to moonrhythm/bsc that referenced this pull request Apr 10, 2023
acoshift added a commit to moonrhythm/bsc that referenced this pull request Apr 17, 2023
acoshift added a commit to moonrhythm/bsc that referenced this pull request May 23, 2023
acoshift added a commit to moonrhythm/bsc that referenced this pull request Jun 30, 2023
acoshift added a commit to moonrhythm/bsc that referenced this pull request Jul 26, 2023
acoshift added a commit to moonrhythm/bsc that referenced this pull request Feb 25, 2024
acoshift added a commit to moonrhythm/bsc that referenced this pull request Apr 14, 2024
acoshift added a commit to moonrhythm/bsc that referenced this pull request Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants