feat: adapt to new go-sdk and greenfield version #47
Conversation
go.mod
Outdated
| github.com/btcsuite/btcd => github.com/btcsuite/btcd v0.23.0 | ||
| github.com/cometbft/cometbft => github.com/bnb-chain/greenfield-cometbft v0.0.1 | ||
| github.com/confio/ics23/go => github.com/cosmos/cosmos-sdk/ics23/go v0.8.0 | ||
| github.com/cosmos/cosmos-sdk => github.com/bnb-chain/greenfield-cosmos-sdk v0.2.1 | ||
| github.com/cosmos/cosmos-sdk => github.com/bnb-chain/greenfield-cosmos-sdk v0.2.2-alpha.1 |
There was a problem hiding this comment.
Can we use the formal release?
go.mod
Outdated
| @@ -6,9 +6,9 @@ require ( | |||
| cosmossdk.io/math v1.0.0 | |||
| github.com/avast/retry-go/v4 v4.3.1 | |||
| github.com/aws/aws-sdk-go v1.40.45 | |||
| github.com/bnb-chain/greenfield v0.2.1 | |||
| github.com/bnb-chain/greenfield v0.2.2-alpha.2 | |||
There was a problem hiding this comment.
Can we use the formal release?
| } | ||
| logging.Logger.Infof("latest attested challenge ids: %+v", challengeIds) | ||
| a.mtx.Lock() | ||
| a.updateAttestedCacheAndEventStatus(a.attestedChallengeIds, challengeIds) |
There was a problem hiding this comment.
In each call, it will return all the 300 latest attested challenges. We should use some cache to filter out the ids which had been written to database. Otherwise, there are lots of useless database write/read.
config/config.go
Outdated
| if !ok { | ||
| panic("error converting fee_amount to math.Int") | ||
| } | ||
| if feeAmount.IsNegative() { |
There was a problem hiding this comment.
better to check whether it is positive or not
submitter/tx_submitter.go
Outdated
| s.cachedEventHash = make(map[uint64][]byte, 0) | ||
| } | ||
|
|
||
| time.Sleep(TxSubmitLoopInterval) |
There was a problem hiding this comment.
better to use ticker
| } | ||
| time.Sleep(executor.QueryAttestedChallengeInterval) | ||
|
|
||
| time.Sleep(common.RetryInterval) |
There was a problem hiding this comment.
actually, we can use the end time in res to determine how long we should wait.
| continue | ||
| } | ||
| time.Sleep(50 * time.Millisecond) | ||
| time.Sleep(TxSubmitInterval) |
There was a problem hiding this comment.
5s seems too long for TxSubmitInterval here.
meanwhile, we can also use attestPeriodEnd to jump out of the loop - by comparing current time and the end time of attestPeriodEnd
submitter/tx_submitter.go
Outdated
| submitLoopCount++ | ||
| if submitLoopCount == common.CacheClearIterations { | ||
| submitLoopCount = 0 | ||
| s.cachedEventHash = make(map[uint64][]byte, common.CacheSize) | ||
| s.cachedEventHash = make(map[uint64][]byte, 0) |
There was a problem hiding this comment.
We can use a lru cache instead of map for caching.
|
There are many changes. Self testing in dev environment is needed. |
Description
Update current code to adapt to dependencies
Refactor code to make it cleaner
Rationale
Multiple dependencies require a change on challenger to continue functioning
Example
Changes
Notable changes: