Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

txpool: enhance some logs and metrics on broadcasting and annoucing #41

Merged
merged 13 commits into from
Jan 5, 2024

Conversation

andyzhang2023
Copy link
Contributor

Description

add logs and metrics for transaction broadcasting and announcing.

Rationale

these logs and metrics reveals the details if any transaction is lost or rejected during the procedure of broadcasting and announcing.
two metrics added for monitoring:

eth/fetcher/transaction/announces/abandon:  "transactions dropped before being announced"
eth/fetcher/transaction/broadcasts/abandon:  "transactions dropped before being broadcasted"

owen-reorg
owen-reorg previously approved these changes Jan 5, 2024
redhdx
redhdx previously approved these changes Jan 5, 2024
eth/fetcher/tx_fetcher.go Outdated Show resolved Hide resolved
andyzhang2023 added 2 commits January 5, 2024 14:52
@andyzhang2023 andyzhang2023 dismissed stale reviews from redhdx and owen-reorg via 5d1d1c9 January 5, 2024 06:53
@owen-reorg owen-reorg merged commit 69afb85 into bnb-chain:develop Jan 5, 2024
1 check failed
sunny2022da added a commit to sunny2022da/op-geth that referenced this pull request Aug 20, 2024
Co-authored-by: Sunny <sunny2022.za@gmail.com>
sunny2022da added a commit to sunny2022da/op-geth that referenced this pull request Aug 20, 2024
sunny2022da added a commit to sunny2022da/op-geth that referenced this pull request Sep 25, 2024
Co-authored-by: Sunny <sunny2022.za@gmail.com>
sunny2022da added a commit to sunny2022da/op-geth that referenced this pull request Oct 11, 2024
Co-authored-by: Sunny <sunny2022.za@gmail.com>
welkin22 pushed a commit that referenced this pull request Oct 22, 2024
Co-authored-by: Sunny <sunny2022.za@gmail.com>
sunny2022da added a commit to sunny2022da/op-geth that referenced this pull request Nov 14, 2024
Co-authored-by: Sunny <sunny2022.za@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants