-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
txpool: enhance some logs and metrics on broadcasting and annoucing #41
Merged
owen-reorg
merged 13 commits into
bnb-chain:develop
from
andyzhang2023:impr/txpool-add-logs
Jan 5, 2024
Merged
txpool: enhance some logs and metrics on broadcasting and annoucing #41
owen-reorg
merged 13 commits into
bnb-chain:develop
from
andyzhang2023:impr/txpool-add-logs
Jan 5, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feature: add tx send logs
…hang2023/op-geth into impr/txpool-add-logs
owen-reorg
previously approved these changes
Jan 5, 2024
redhdx
previously approved these changes
Jan 5, 2024
bendanzhentan
suggested changes
Jan 5, 2024
…hang2023/op-geth into impr/txpool-add-logs
bendanzhentan
approved these changes
Jan 5, 2024
owen-reorg
approved these changes
Jan 5, 2024
sunny2022da
added a commit
to sunny2022da/op-geth
that referenced
this pull request
Aug 20, 2024
Co-authored-by: Sunny <sunny2022.za@gmail.com>
sunny2022da
added a commit
to sunny2022da/op-geth
that referenced
this pull request
Aug 20, 2024
This reverts commit d3fc63a.
sunny2022da
added a commit
to sunny2022da/op-geth
that referenced
this pull request
Sep 25, 2024
Co-authored-by: Sunny <sunny2022.za@gmail.com>
sunny2022da
added a commit
to sunny2022da/op-geth
that referenced
this pull request
Oct 11, 2024
Co-authored-by: Sunny <sunny2022.za@gmail.com>
welkin22
pushed a commit
that referenced
this pull request
Oct 22, 2024
Co-authored-by: Sunny <sunny2022.za@gmail.com>
sunny2022da
added a commit
to sunny2022da/op-geth
that referenced
this pull request
Nov 14, 2024
Co-authored-by: Sunny <sunny2022.za@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
add logs and metrics for transaction broadcasting and announcing.
Rationale
these logs and metrics reveals the details if any transaction is lost or rejected during the procedure of broadcasting and announcing.
two metrics added for monitoring: